-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PkgConfigDeps] Creates *.pc
files for test_requires
#11390
[PkgConfigDeps] Creates *.pc
files for test_requires
#11390
Conversation
for _, dep in host_req.items(): | ||
build_req = self._conanfile.dependencies.direct_build | ||
test_req = self._conanfile.dependencies.test | ||
for _, dep in list(host_req.items()) + list(build_req.items()) + list(test_req.items()): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any risk of pkg-config files from different contexts overriding each other? like build_requiries(protobuf)
+ requires(protobuf)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but that's a problem that you could even have with other components. Have a look at this PR #10263 So, you should change that pkg_config_name
/pkg_config_aliases
property.
assert "Requires: OpenCL" in get_requires_from_content(pc_content) | ||
|
||
|
||
def test_pkgconfigdeps_with_test_requires(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@memsharded This is the new one. The rest of the diff is only a code movement.
*.pc
files for build_requires
and test_requires
*.pc
files for test_requires
Changelog: Bugfix:
PkgConfigDeps
creates*.pc
files fortest_requires
.Docs: omit
Closes: #11376